openssl: fix mingw cross build by disabling patch #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improve exception message, comment that parallel building seems to work but doesn't yield much faster builds
4.6.3 causes .exe files to segfault
| # bundle) to be set through the environment variable | ||
| # ‘OPENSSL_X509_CERT_FILE’. This is necessary because the | ||
| # default location ($out/ssl/cert.pem) doesn't exist, and | ||
| # hardcoding something like /etc/ssl/cert.pem is impure and | ||
| # cannot be overriden per-process. For security, the | ||
| # environment variable is ignored for setuid binaries. | ||
| ./cert-file.patch |
There was a problem hiding this comment.
What is the build error you get when using this patch?
It might be better to fix it, rather than to omit it in order to have consistent behavior across architectures.
|
The patch can be disabled for cross-builds only, using crossAttrs. And in any case, the comment shouldn't be left intact. |
|
@MarcWeber, do you intend to update this patch so that it can be applied to the current master branch (and addresses the issue raised by aszlig)? |
|
At the moment I'm not interested in cross building. If aszlig has time to update fix the patch the better. |
|
I'll close the issue until someone has time to revive this patch. |
edolstra
pushed a commit
to edolstra/nixpkgs
that referenced
this pull request
Oct 1, 2013
mkdir musicDirecotry for mpd before startnig the service
12 tasks
Profpatsch
pushed a commit
that referenced
this pull request
Jun 20, 2020
This is pretty much a copy of XPS 9370, without kaby-laky and the throttle bug. I was getting lockups with the kaby-laky changes and the throttle bug did not seem to have an impact either way.
ethancedwards8
pushed a commit
to ethancedwards8/nixpkgs
that referenced
this pull request
Apr 2, 2021
[services.emacs] use `fg-daemon` flag for service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve exception message, comment that parallel building seems to work
but doesn't yield much faster builds